brave /
brave-browser #236
brave /
brave-browser #236
0.00
FND
Description
Extension crash when clearing browsing history
New steps to reproduce the issue
- Build from source
- Add Honey extension from CWS and add browsing hisotry
- Clear browser history and close browser
- Run
npm run sync -- --allandnpm run build -- Release - Launch browser with
npm run start -- Release - Wait for a couple of mins and then Honey crashed message is shown
Original Steps for issue
- Install honey from webstore
- Ensure you have good browsing history and then clear browsing history
- Extension crashes and shows notification about crash
Actual result:
Extension crashes when clearing browsing data. Console logs this error
ERROR:CONSOLE(1)] "Uncaught ReferenceError: cr is not defined", source: chrome://settings/clearBrowserData (1)
Expected result:
Extensions should not crash
Reproduces how often:
Easy
Brave version (about:brave info)
Comments
Comments posted on the request
I was unable to reproduce with current brave-browser stable, Version 0.54.0 Chromium: 68.0.3440.68
@srirambv Is this still an issue for you? If so, could you provide more info about your environment and what you mean by "good browsing history" in the STR?
@srirambv can you reproduce still? If not let's close.
what you mean by "good browsing history" in the STR?
Just a good amount of browsing history may be for about a weeks worth of browsing data.
@bbondy Unable to test as install is blocked
@srirambv still a problem?
Retested the issue with original steps from issue
Release build from source
- Installed Honey on a profile with good amount of browsing history, profile also had 1Password previously installed
- Cleared browsing history
- Browser crashed(Crash ID ffb85dacd4d3e72b) and 1Password showed notification of crash
Tried the same steps on 0.54.4
- Installed Honey on an upgrade profile which had a good amount of browsing history
- Cleared browsing data
- Nothing crashed, Browser remained open and active, extension didn't show any notification of crash
This is fixed on 0.55.2 on Windows.
Happens on Release build from source. Don't even have to clear browsing history. just launch and wait for a couple of minutes and crashed message shows up
cc: @bbondy
Still happens on b27f6db
Extension only crashes when the browser is launched. Here's exactly what i did on b27f6db
git pullon brave/brave-browser(master)npm run sync -- --allon brave/brave-browser(master)npm run build -- Releaseon brave/brave-browser(master)npm run start -- Release- Leave the browser open for a min and the extension crashed message shows up. Didn't even have to clear browsing history and relaunch the browser
@srirambv does this only happen when running b-c from source?
@kjozwiak yes. I've updated the original issue with new steps to reproduce as well.
@bbondy do we care if this is only crashing when building from source?
Since it seems like this happens with release builds, it should stay open.
I'll move to backlog for normal prioritization though.
This issue has been funded using FundRequest. A developer can claim the reward by submitting a pull request referencing this issue. (How to Close Issues via Pull Requests?) e.g.
fixes #236