brave /
brave-browser #236
0.00
FND
Extension crash when clearing browsing history
npm run sync -- --all and npm run build -- Releasenpm run start -- ReleaseExtension crashes when clearing browsing data. Console logs this error
ERROR:CONSOLE(1)] "Uncaught ReferenceError: cr is not defined", source: chrome://settings/clearBrowserData (1)
Extensions should not crash
Easy
I was unable to reproduce with current brave-browser stable, Version 0.54.0 Chromium: 68.0.3440.68
@srirambv Is this still an issue for you? If so, could you provide more info about your environment and what you mean by "good browsing history" in the STR?
@srirambv can you reproduce still? If not let's close.
what you mean by "good browsing history" in the STR?
Just a good amount of browsing history may be for about a weeks worth of browsing data.
@bbondy Unable to test as install is blocked

@srirambv still a problem?
Retested the issue with original steps from issue
Release build from source

Tried the same steps on 0.54.4
This is fixed on 0.55.2 on Windows.
Happens on Release build from source. Don't even have to clear browsing history. just launch and wait for a couple of minutes and crashed message shows up
cc: @bbondy
Still happens on b27f6db


Extension only crashes when the browser is launched. Here's exactly what i did on b27f6db
git pull on brave/brave-browser(master)npm run sync -- --all on brave/brave-browser(master)npm run build -- Release on brave/brave-browser(master)npm run start -- Release@srirambv does this only happen when running b-c from source?
@kjozwiak yes. I've updated the original issue with new steps to reproduce as well.
@bbondy do we care if this is only crashing when building from source?
Since it seems like this happens with release builds, it should stay open.
I'll move to backlog for normal prioritization though.
This issue has been funded using FundRequest. A developer can claim the reward by submitting a pull request referencing this issue. (How to Close Issues via Pull Requests?) e.g.
fixes #236